Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate config to automate @edx namespaced minor/patch version upgrades #80

Conversation

abdullahwaheed
Copy link
Contributor

Ticket

Create common renovate config that automates @edx namespaced minor/patch version upgrades

What has changed

Added Renovate config to update and auto merge @edx name spaced minor and patch packages.
As no schedule is provided, it will create and merge renovate PRs at any time

Copy link
Contributor

@hurtstotouchfire hurtstotouchfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdullahwaheed / @arbrandes Do we have a plan for situations like the Paragon 20 upgrade (with breaking changes) being hidden behind minor version upgrades of header / footer?

@arbrandes
Copy link
Contributor

@hurtstotouchfire, good point. However, such an upgrade should by definition be "major". If one sneaks by as minor, it's basically a show stopper and should be fixed/reverted immediately.

@hurtstotouchfire
Copy link
Contributor

My understanding is that particular one slipped through because it's not necessarily a breaking change -- depending on what your other dependencies are. I think it was not breaking for Profile but was breaking for a few other MFEs. From what I know though, there is no plan to reverse it or fix the numbering, and I think there are still some MFEs that aren't fully updated yet.

@abdullahwaheed
Copy link
Contributor Author

@hurtstotouchfire yes you are right, that should be major version change. We'll revisit all the MFEs with breaking changes and update the versioning accordingly. Let me create an issue for this as well

@arbrandes
Copy link
Contributor

@abdullahwaheed, can you link to that issue you mention above? Is there anything left to do here?

@abdullahwaheed
Copy link
Contributor Author

@arbrandes i think @hurtstotouchfire can link the issue, I couldn't find it documented other than an old slack chat. For new changes, we are now maintaining breaking changes separately. I think its ok to merge as we have merged it elsewhere

@hurtstotouchfire hurtstotouchfire dismissed their stale review February 9, 2023 14:39

Mainly wanted to raise the issue

@hurtstotouchfire hurtstotouchfire merged commit dbc8c6e into master Feb 9, 2023
@hurtstotouchfire hurtstotouchfire deleted the abdullahwaheed/renovate-bot-edx-packages-auto-update branch February 9, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants