refactor: fix navigations

openedx · Sep 7, 2023 · 1b63ce1 · 1b63ce1
1 parent f6e587c
commit 1b63ce1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/src/course-home/outline-tab/OutlineTab.jsx b/src/course-home/outline-tab/OutlineTab.jsx
@@ -115,7 +115,11 @@ const OutlineTab = ({ intl }) => {
       // Deleting the course_start query param as it only needs to be set once
       // whenever passed in query params.
       currentParams.delete('start_course');
-      navigate(`?${currentParams.toString()}`, { replace: true });
+      navigate({
+        pathname: location.pathname,
+        search: `?${currentParams.toString()}`,
+        replace: true,
+      });
     }
   }, [location.search]);
 

diff --git a/src/decode-page-route/index.jsx b/src/decode-page-route/index.jsx
@@ -39,7 +39,7 @@ const DecodePageRoute = ({ children }) => {
 
     // if the url get decoded, reroute to the decoded url
     if (newUrl !== pathname) {
-      return <Navigate to={newUrl} />;
+      return <Navigate to={newUrl} replace />;
     }
   }
 

diff --git a/src/generic/CourseAccessErrorPage.jsx b/src/generic/CourseAccessErrorPage.jsx
@@ -38,7 +38,7 @@ const CourseAccessErrorPage = ({ intl }) => {
     );
   }
   if (courseStatus === LOADED) {
-    navigate(`/redirect/home/${courseId}`);
+    navigate(`/redirect/home/${courseId}`, { replace: true });
   }
   return (
     <>

diff --git a/src/tab-page/TabPage.jsx b/src/tab-page/TabPage.jsx
@@ -53,7 +53,7 @@ const TabPage = ({ intl, ...props }) => {
   if (courseStatus === 'denied') {
     const redirectUrl = getAccessDeniedRedirectUrl(courseId, activeTabSlug, courseAccess, start);
     if (redirectUrl) {
-      return (<Navigate to={redirectUrl} />);
+      return (<Navigate to={redirectUrl} replace />);
     }
   }