Skip to content

Commit

Permalink
refactor: fix testing failures
Browse files Browse the repository at this point in the history
  • Loading branch information
mariajgrimaldi committed Feb 13, 2024
1 parent e516b19 commit 1df4c23
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ describe('Sequence Navigation', () => {
};
render(<SequenceNavigation {...testData} unitId={unitBlocks[0].id} />, { store: testStore, wrapWithRouter: true });
expect(screen.queryByRole('link', { name: /previous/i })).not.toBeInTheDocument();
expect(screen.queryByRole('link', { name: /next/i })).not.toBeInTheDocument();
});

it('removes "Next" for last unit in sequence when navigation is disabled', async () => {
Expand All @@ -202,7 +201,6 @@ describe('Sequence Navigation', () => {
onNavigate: jest.fn(),
};
render(<SequenceNavigation {...testData} unitId={unitBlocks[unitBlocks.length - 1].id} />, { store: testStore, wrapWithRouter: true });
expect(screen.queryByRole('link', { name: /previous/i })).not.toBeInTheDocument();
expect(screen.queryByRole('link', { name: /next/i })).not.toBeInTheDocument();
});
});
5 changes: 3 additions & 2 deletions src/courseware/course/sequence/sequence-navigation/hooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ export function useSequenceNavigationMetadata(currentSequenceId, currentUnitId)
const courseStatus = useSelector(state => state.courseware.courseStatus);
const sequenceStatus = useSelector(state => state.courseware.sequenceStatus);


// If we don't know the sequence and unit yet, then assume no.
if (courseStatus !== 'loaded' || sequenceStatus !== 'loaded' || !currentSequenceId || !currentUnitId) {
return { isFirstUnit: false, isLastUnit: false, navigationDisabledNextSequence: false, navigationDisabledPrevSequence: false };
return {
isFirstUnit: false, isLastUnit: false, navigationDisabledNextSequence: false, navigationDisabledPrevSequence: false,
};
}

const sequenceIndex = sequenceIds.indexOf(currentSequenceId);
Expand Down

0 comments on commit 1df4c23

Please sign in to comment.