refactor: address PR reviews

openedx · Mar 7, 2024 · 523ab85 · 523ab85
1 parent b12621a
commit 523ab85
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/courseware/course/Course.jsx b/src/courseware/course/Course.jsx
@@ -77,7 +77,7 @@ const Course = ({
         <title>{`${pageTitleBreadCrumbs.join(' | ')} | ${getConfig().SITE_NAME}`}</title>
       </Helmet>
       <div className="position-relative d-flex align-items-center mb-4 mt-1">
-        {!navigationDisabled && (
+        {navigationDisabled || (
         <>
           <CourseBreadcrumbs
             courseId={courseId}

diff --git a/src/courseware/course/sequence/sequence-navigation/SequenceNavigation.jsx b/src/courseware/course/sequence/sequence-navigation/SequenceNavigation.jsx
@@ -73,7 +73,7 @@ const SequenceNavigation = ({
   const renderPreviousButton = () => {
     const disabled = isFirstUnit;
     const prevArrow = isRtl(getLocale()) ? ChevronRight : ChevronLeft;
-    return !navigationDisabledPrevSequence && (
+    return navigationDisabledPrevSequence || (
       <Button
         variant="link"
         className="previous-btn"
@@ -94,7 +94,7 @@ const SequenceNavigation = ({
     const disabled = isLastUnit && !exitActive;
     const nextArrow = isRtl(getLocale()) ? ChevronLeft : ChevronRight;
 
-    return !navigationDisabledNextSequence && (
+    return navigationDisabledNextSequence || (
       <Button
         variant="link"
         className="next-btn"

diff --git a/src/courseware/course/sequence/sequence-navigation/hooks.js b/src/courseware/course/sequence/sequence-navigation/hooks.js
@@ -30,7 +30,7 @@ export function useSequenceNavigationMetadata(currentSequenceId, currentUnitId)
   const isLastSequence = sequenceIndex === sequenceIds.length - 1;
   const isLastUnitInSequence = unitIndex === sequence.unitIds.length - 1;
   const isLastUnit = isLastSequence && isLastUnitInSequence;
-  const sequenceNavigationDisabled = sequence?.navigationDisabled;
+  const sequenceNavigationDisabled = sequence.navigationDisabled;
   const navigationDisabledPrevSequence = sequenceNavigationDisabled && isFirstUnitInSequence;
   const navigationDisabledNextSequence = sequenceNavigationDisabled && isLastUnitInSequence;