fix: Updated code to avoid mutation

openedx · Oct 25, 2023 · 6852d4b · 6852d4b
1 parent 382f101
commit 6852d4b
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/course-home/courseware-search/CoursewareSearchResults.jsx b/src/course-home/courseware-search/CoursewareSearchResults.jsx
@@ -31,12 +31,11 @@ const CoursewareSearchResults = ({ intl, results }) => {
         const key = type.toLowerCase();
         const icon = iconTypeMapping[key] || defaultIcon;
 
-        const linkProps = { href };
-
-        if (isExternal) {
-          linkProps.target = '_blank';
-          linkProps.rel = 'nofollow';
-        }
+        const linkProps = isExternal ? {
+          href,
+          target: '_blank',
+          rel: 'nofollow',
+        } : { href };
 
         return (
           <a className="courseware-search-results__item" {...linkProps}>