-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RTL for Handouts #1288
Fix RTL for Handouts #1288
Conversation
Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #1288 +/- ##
=============================================================
Coverage ? 88.05%
=============================================================
Files ? 266
Lines ? 4519
Branches ? 1143
=============================================================
Hits ? 3979
Misses ? 526
Partials ? 14 ☔ View full report in Codecov by Sentry. |
Hey @dyudyunov, thank you for this contribution. I'm assuming that the changes are ready for review, but let me know if you were planning to continue working on them. |
Hi! Please note that this reapplies already merged changes to open-release/palm.master #1192 |
@openedx/2u-aurora Could you give this a quick look and merge the changes? It's a backport of a PR that had already been approved by Aurora earlier, so it should be quick to do. CC @jristau1984, in case Aurora is no longer the right team to ping here (?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
7ff00fa
into
openedx:open-release/quince.master
@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Ok, it looks like we did things a little backwards, here. To avoid issues down the road, we should always try to merge things to master first, and only then to get the backport(s) merged. Anyway, I'll use the upside here, which is that this has apparently been working in Palm and Quince, to try and get the one to master merged fast. |
This was already merged into Palm #1192
Before the fix:
After the fix: