Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTL for Handouts #1288

Conversation

dyudyunov
Copy link
Contributor

This was already merged into Palm #1192

Before the fix:

Screenshot 2024-02-09 at 18 01 14

After the fix:

Screenshot 2024-02-09 at 17 23 57

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 9, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@b24568f). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master    #1288   +/-   ##
=============================================================
  Coverage                              ?   88.05%           
=============================================================
  Files                                 ?      266           
  Lines                                 ?     4519           
  Branches                              ?     1143           
=============================================================
  Hits                                  ?     3979           
  Misses                                ?      526           
  Partials                              ?       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd
Copy link

itsjeyd commented Feb 16, 2024

Hey @dyudyunov, thank you for this contribution. I'm assuming that the changes are ready for review, but let me know if you were planning to continue working on them.

@itsjeyd itsjeyd added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. backport PR backports a change from main to a named release. labels Feb 16, 2024
@dyudyunov
Copy link
Contributor Author

dyudyunov commented Feb 16, 2024

Hey @dyudyunov, thank you for this contribution. I'm assuming that the changes are ready for review, but let me know if you were planning to continue working on them.

Hi!
Yes, it's ready

Please note that this reapplies already merged changes to open-release/palm.master #1192

@itsjeyd
Copy link

itsjeyd commented Mar 11, 2024

@openedx/2u-aurora Could you give this a quick look and merge the changes? It's a backport of a PR that had already been approved by Aurora earlier, so it should be quick to do.

CC @jristau1984, in case Aurora is no longer the right team to ping here (?).

Copy link
Contributor

@leangseu-edx leangseu-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@leangseu-edx leangseu-edx merged commit 7ff00fa into openedx:open-release/quince.master Mar 11, 2024
6 checks passed
@openedx-webhooks
Copy link

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@dyudyunov dyudyunov deleted the fix-handouts-rtl-quince branch March 11, 2024 14:00
@arbrandes
Copy link

Ok, it looks like we did things a little backwards, here. To avoid issues down the road, we should always try to merge things to master first, and only then to get the backport(s) merged.

Anyway, I'll use the upside here, which is that this has apparently been working in Palm and Quince, to try and get the one to master merged fast.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants