Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KBK-43] Add Courseware search - tabbed filters #1225

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

aethant
Copy link
Contributor

@aethant aethant commented Oct 26, 2023

KBK-43

Add courseware search results filter container

image image image image

@aethant aethant force-pushed the atelischak/courseware-search-tab-filters branch from bb72f77 to 984eec8 Compare October 26, 2023 20:19
@aethant aethant marked this pull request as ready for review October 26, 2023 20:20
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c257048) 88.18% compared to head (efdba33) 88.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1225      +/-   ##
==========================================
+ Coverage   88.18%   88.24%   +0.06%     
==========================================
  Files         273      274       +1     
  Lines        4620     4628       +8     
  Branches     1164     1165       +1     
==========================================
+ Hits         4074     4084      +10     
+ Misses        531      530       -1     
+ Partials       15       14       -1     
Files Coverage Δ
...home/courseware-search/CoursewareResultsFilter.jsx 100.00% <100.00%> (ø)
...course-home/courseware-search/CoursewareSearch.jsx 71.42% <ø> (+6.72%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aethant aethant force-pushed the atelischak/courseware-search-tab-filters branch from f5e8865 to efdba33 Compare October 27, 2023 14:13
@aethant aethant merged commit ce24a58 into master Oct 27, 2023
5 checks passed
@aethant aethant deleted the atelischak/courseware-search-tab-filters branch October 27, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants