Endpoint usage implementation for Courseware Search #1232
Conversation
rijuma
changed the title
rijuma
changed the title
rijuma
force-pushed
the
rijuma/courseware-search-integration
branch
from
3db6ac0 to
0c37f9c
Compare
Co-authored-by: Simon Chen <[email protected]>
rijuma
force-pushed
the
rijuma/courseware-search-integration
branch
from
0c37f9c to
cec3b00
Compare
| content: { | ||
| displayName, | ||
| htmlContent, | ||
| transcriptEn, |
There was a problem hiding this comment.
we might find more of these types that have to be located like you do here and mapped like you do below, it might make sense to pull the content handling out to a separate controllable function
| took, total, maxScore, accessDeniedCount, | ||
| } = data; | ||
|
|
||
| // TODO: Remove when publishing to prod. Just temporary for performance debugging. |
There was a problem hiding this comment.
this is nice, is there a way we can have it do this in prod if we set some local something in the browser to turn it on?
There was a problem hiding this comment.
Agree. Maybe we can just leave this here? Or figure out a way to send this result to Newrelic or other monitoring tools?
There was a problem hiding this comment.
Due this is not sensitive information, we can leave this until find the best tool for tracking this, like Kibana or similars.
| took, total, maxScore, accessDeniedCount, | ||
| } = data; | ||
|
|
||
| // TODO: Remove when publishing to prod. Just temporary for performance debugging. |
There was a problem hiding this comment.
Agree. Maybe we can just leave this here? Or figure out a way to send this result to Newrelic or other monitoring tools?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1232 +/- ##
==========================================
- Coverage 88.20% 87.46% -0.74%
==========================================
Files 274 275 +1
Lines 4628 4723 +95
Branches 1165 1193 +28
==========================================
+ Hits 4082 4131 +49
- Misses 532 575 +43
- Partials 14 17 +3
☔ View full report in Codecov by Sentry. |
germanolleunlp
changed the title
Description
Ticket: KBK-45 🔒
This change takes the the Search Results UI components 🔒 and connects it to the search endpoint. I'm taking some small liberties on the design and added some extra changes to the components due to some unplanned adaptations I had to make.
Important
These changes add he
joidependency to be used on payload validation.UI changes
Showing results
Added error alert in case of endpoint failure or wrong payload format.
Testing Instructions:
This feature is behind a Waffle Flag. In order to test it: