Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: notification made forum click rate drop #1237

Merged
merged 1 commit into from
Nov 17, 2023
Merged

revert: notification made forum click rate drop #1237

merged 1 commit into from
Nov 17, 2023

Conversation

leangseu-edx
Copy link
Contributor

@leangseu-edx leangseu-edx commented Nov 17, 2023 •
edited
Loading

revert #1234

mattcarter
mattcarter approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@codecov Codecov
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c38d69f) 87.46% compared to head (0e58233) 87.46%.

Files Patch % Lines
src/courseware/course/Course.jsx 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1237   +/-   ##
=======================================
  Coverage   87.46%   87.46%           
=======================================
  Files         275      275           
  Lines        4721     4723    +2     
  Branches     1192     1193    +1     
=======================================
+ Hits         4129     4131    +2     
  Misses        575      575           
  Partials       17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattcarter mattcarter merged commit 748e73d into master Nov 17, 2023
5 of 6 checks passed
@mattcarter mattcarter deleted the lk/revert-notification branch November 17, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcarter mattcarter mattcarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leangseu-edx @mattcarter