feat: Added Plugin Slot wrapping UpgradeNotification in NotificationTray #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/upgrade-plugin-slots #1367 +/- ##
============================================================
Coverage ? 88.28%
============================================================
Files ? 293
Lines ? 5010
Branches ? 1237
============================================================
Hits ? 4423
Misses ? 571
Partials ? 16 ☔ View full report in Codecov by Sentry. |
zacharis278
approved these changes
Apr 22, 2024
arbrandes
reviewed
Apr 26, 2024
| pluginProps={{ upgradeNotificationProps }} | ||
| testId="notification-tray-slot" | ||
| > | ||
| <UpgradeNotification {...upgradeNotificationProps} /> |
There was a problem hiding this comment.
A few things:
- The
verifiedModecheck should be removed, and instead delegated topluginProps - The
UpgradeNotificationcomponent should not be present by default - If there are no other uses of
UpgradeNotification, the component itself should be removed from the codebase - The props are far too feature-specific; we should probably rely on global context in the future
There was a problem hiding this comment.
@arbrandes can we move this conversation to open PR into main here since this was just a subset of the work? #1368
There was a problem hiding this comment.
Of course! I didn't realize this was a PR into a feature branch. :)
varshamenon4
pushed a commit
that referenced
this pull request
May 2, 2024
schenedx
pushed a commit
that referenced
this pull request
May 13, 2024
* feat: add plugin slot for fbe lock paywall (#1347) * feat: Added PluginSlot wrapping UpgradeNotification components (#1366) * chore: Updated PluginSlot mock to support children and test ids * chore: Updated mocked PluginSlot * chore: Added unit test for MockedPluginSlot * fix: Updated slot name ids * feat: Added Plugin Slot wrapping UpgradeNotification in NotificationTray (#1367) * fix: Removed PluginSlot prop scoping for UpgradeNotification (#1369) * feat: generic sidebar notification plugin (#1379) * feat: make notification plugin api generic * feat: include new sidebar and tests * feat: tweak sidebar toggle * style: fix extra space from merge * feat: rename plugin slots --------- Co-authored-by: Alison Langston <[email protected]> Co-authored-by: Zachary Hancock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: COSMO-246 🔒
In my previous PR #1366 I forgot to add an extra slot in the
NotificationsTrywrapping theUpgradeNotificationscomponent.