feat: add Skills Builder Header component, refactor to use ModalDialog #682
Conversation
justinhynes
force-pushed
the
jhynes/aper-2258
branch
2 times, most recently
from
c53c3f0 to
f88c4ab
Compare
Codecov ReportBase: 65.42% // Head: 65.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 65.42% 65.58% +0.16%
==========================================
Files 54 56 +2
Lines 830 834 +4
Branches 158 158
==========================================
+ Hits 543 547 +4
Misses 277 277
Partials 10 10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/skills-builder/skills-builder-header/SkillsBuilderHeader.jsx
Outdated
Show resolved
Hide resolved
src/skills-builder/skills-builder-header/skillsBuilderHeader.scss
Outdated
Show resolved
Hide resolved
[APER-2258] This PR adds the SkillsBuilderHeader component to the profile MFE. There was also some additional refactoring work required to display the header in the modal. The FullscreenModal component is not flexible enough to allow custom header designs to be displayed (only text). We have to pivot to using the `ModalDialog` family of components instead.
justinhynes
force-pushed
the
jhynes/aper-2258
branch
from
f5623e7 to
dbf716e
Compare
| }, | ||
| skillsBuilderHeaderSubheading: { | ||
| id: 'skills.builder.header.subheading', | ||
| defaultMessage: 'Let edX be your guide', |
There was a problem hiding this comment.
Hi - this pull request (specifically this line) introduced a bug:
Could you please address by refactoring the edX-specific language out of strings? Thank you.
[APER-2258]
This PR adds the SkillsBuilderHeader component to the profile MFE.
There was also some additional refactoring work required to display the header in the modal. The
FullscreenModalcomponent is not flexible enough to allow custom header designs to be displayed (only text). We have to pivot to using theModalDialogfamily of components instead.