-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fields visibility and visibility forms #864
feat: Fields visibility and visibility forms #864
Conversation
vladislavkeblysh
commented
Oct 10, 2023
•
edited
Loading
edited
- Fixed the display of fields in a user's profile when viewing it from our own account to another user's profile that was just created (by default, the fields Full name, Location, and Certificates (if any) are displayed).
- Fixed the display of empty fields in a user's profile when viewing it from our own account to another user's profile that was just created. Fields that are not filled in will not be displayed (previously, if a field was not filled in, the field name was displayed, but not the value).
- Fixed the behavior of forms for a newly created user. Previously, if you changed the value of one field to Just me for the first time, the values of other fields were also reset to Just me. Now, only the value of the edited field is changed.
Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@vladislavkeblysh seeing some linting failures. |
482d644
to
78efcd7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #864 +/- ##
==========================================
+ Coverage 66.22% 66.82% +0.60%
==========================================
Files 52 52
Lines 823 850 +27
Branches 158 176 +18
==========================================
+ Hits 545 568 +23
- Misses 268 272 +4
Partials 10 10
☔ View full report in Codecov by Sentry. |
@e0d Fixed |
I'll be taking a look at this today! |
@vladislavkeblysh Should we also be preparing a backport of this functionality to Quince now that the branches are cut for the next release? (Sorry to create extra work) |
@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |