fix: fit & finish profile card plugin #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add Plugin Framework to top of Profile directory
Update browserslist DB
…ofile into jwesson/prettify-profile-plugin
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ProfilePluginPOC #870 +/- ##
===================================================
Coverage ? 63.66%
===================================================
Files ? 54
Lines ? 856
Branches ? 161
===================================================
Hits ? 545
Misses ? 301
Partials ? 10 ☔ View full report in Codecov by Sentry. |
cdeery
reviewed
Oct 17, 2023
There was a problem hiding this comment.
nice job refactoring this out of the editable component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will design the Profile Plugin into a card shape that mimics as closely as possible to the mock design attached in APER-2965.