Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replaced deprecated Paragon form components #761

Conversation

abdullahwaheed
Copy link
Contributor

Ticket

Migrate off deprecated Paragon components

What has changed

Updated deprecated InputText to Form.Control and InputSelect to Form.Control.

Important: We have to use ReduxForm validations in place of HTML validations to get proper validation errors provided by Paragon

@mphilbrick211
Copy link

mphilbrick211 commented Oct 26, 2022

Hi @abdullahwaheed! If you plan to proceed with this PR, could you please rebase and request review?

@mphilbrick211 mphilbrick211 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 7, 2022
@arbrandes
Copy link
Contributor

@abdullahwaheed, looks like the PR is approved, but we need a rebase to resolve conflicts.

@mphilbrick211
Copy link

Hi @abdullahwaheed! Friendly ping on Adolfo's comment above re: rebasing.

@abdullahwaheed
Copy link
Contributor Author

@arbrandes @mphilbrick211 rebase done with master, please merge this

@arbrandes arbrandes changed the title Paragon form component deprecations refactor: replaced deprecated Paragon form components Dec 8, 2022
@arbrandes arbrandes merged commit b6a2d3e into openedx:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants