-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replaced deprecated Paragon form components #761
Merged
arbrandes
merged 8 commits into
openedx:master
from
abdullahwaheed:abdullahwaheed/paragon-form-deprecations
Dec 8, 2022
Merged
refactor: replaced deprecated Paragon form components #761
arbrandes
merged 8 commits into
openedx:master
from
abdullahwaheed:abdullahwaheed/paragon-form-deprecations
Dec 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bdullahwaheed/paragon-form-deprecations
ansabgillani
approved these changes
Aug 18, 2022
…bdullahwaheed/paragon-form-deprecations
…bdullahwaheed/paragon-form-deprecations
Hi @abdullahwaheed! If you plan to proceed with this PR, could you please rebase and request review? |
mphilbrick211
added
the
waiting on author
PR author needs to resolve review requests, answer questions, fix tests, etc.
label
Nov 7, 2022
26 tasks
@abdullahwaheed, looks like the PR is approved, but we need a rebase to resolve conflicts. |
Hi @abdullahwaheed! Friendly ping on Adolfo's comment above re: rebasing. |
…bdullahwaheed/paragon-form-deprecations
@arbrandes @mphilbrick211 rebase done with master, please merge this |
arbrandes
changed the title
Paragon form component deprecations
refactor: replaced deprecated Paragon form components
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
waiting on author
PR author needs to resolve review requests, answer questions, fix tests, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Migrate off deprecated Paragon components
What has changed
Updated deprecated
InputText
toForm.Control
andInputSelect
toForm.Control
.Important: We have to use ReduxForm validations in place of HTML validations to get proper validation errors provided by Paragon