Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate off paragon modal deprecated component #784

Merged

Conversation

Mashal-m
Copy link
Contributor

Ticket

Migrate off deprecated Paragon components

What has changed?

  • Migrate off paragon modal deprecation in ConfirmationModal.jsx

Before

Screenshot 2022-10-11 at 11 13 28 AM

Screenshot 2022-10-11 at 11 13 28 AM

@arbrandes
Copy link
Contributor

@Mashal-m, looks like we need a rebase! Might fix the failing test, too.

@arbrandes
Copy link
Contributor

@Mashal-m, looks like we have test failures. Mind taking a look?

@Mashal-m
Copy link
Contributor Author

Mashal-m commented Feb 3, 2023

@Mashal-m, looks like we have test failures. Mind taking a look?

Unit tests fixed, I have requested PR review and merge to the owner squad!

@Mashal-m
Copy link
Contributor Author

Mashal-m commented May 5, 2023

@Ali-D-Akbar could you please merge this as well? we do not have access.

@Ali-D-Akbar Ali-D-Akbar merged commit 2e877fc into openedx:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants