-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add search menu button to header [FC-0040] #474
feat: add search menu button to header [FC-0040] #474
Conversation
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
3956017
to
154db29
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #474 +/- ##
==========================================
+ Coverage 66.86% 67.15% +0.29%
==========================================
Files 24 24
Lines 338 341 +3
Branches 78 80 +2
==========================================
+ Hits 226 229 +3
Misses 110 110
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good @rpenido, great work!
- I tested this: I checked the test cases and manually tested its functionality as described in the PR description
- I read through the code
-
I checked for accessibility issues -
Includes documentation
@arbrandes or @brian-smith-tcril Would one of you have time this week to review and merge this small PR for us? We (OpenCraft) don't have any Core Contributor for this repo afaik. It's blocking some other work and required for the search feature that we want to get into Redwood. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM!
Is this something the product/ui/ux WG is aware of? If we could either get a 👍 from them on this PR or a link to a something noting this UI change is approved that'd be perfect.
This has product approval, it's part of the larger content tagging initiative which has been ongoing since before product proposal operations were solidified. |
@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds a new "Search content" button in the Studio Header.
Desktop:
Mobile:
The icon is only shown if a
searchButtonAction
props is provided to theStudioHeader
component.More Information
Part of:
Testing Instructions
Internal ref: FAL-3693