Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add search menu button to header [FC-0040] #474

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Mar 28, 2024

Description

This PR adds a new "Search content" button in the Studio Header.
Desktop:
image
Mobile:
image

The icon is only shown if a searchButtonAction props is provided to the StudioHeader component.

More Information

Part of:

Testing Instructions


Internal ref: FAL-3693

@openedx-webhooks
Copy link

openedx-webhooks commented Mar 28, 2024

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 28, 2024
@rpenido rpenido force-pushed the rpenido/fal-3693-add-search-menu-button branch from 3956017 to 154db29 Compare March 28, 2024 18:50
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.15%. Comparing base (10619ce) to head (154db29).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
+ Coverage   66.86%   67.15%   +0.29%     
==========================================
  Files          24       24              
  Lines         338      341       +3     
  Branches       78       80       +2     
==========================================
+ Hits          226      229       +3     
  Misses        110      110              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpenido rpenido marked this pull request as ready for review March 29, 2024 13:44
@rpenido rpenido changed the title feat: add search menu button to header feat: add search menu button to header [FC-0040] Mar 29, 2024
@rpenido rpenido requested a review from yusuf-musleh March 29, 2024 15:48
Copy link
Member

@yusuf-musleh yusuf-musleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good @rpenido, great work!

  • I tested this: I checked the test cases and manually tested its functionality as described in the PR description
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@bradenmacdonald
Copy link

@arbrandes or @brian-smith-tcril Would one of you have time this week to review and merge this small PR for us? We (OpenCraft) don't have any Core Contributor for this repo afaik. It's blocking some other work and required for the search feature that we want to get into Redwood.

@brian-smith-tcril brian-smith-tcril self-requested a review April 3, 2024 13:53
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM!

Is this something the product/ui/ux WG is aware of? If we could either get a 👍 from them on this PR or a link to a something noting this UI change is approved that'd be perfect.

@jmakowski1123
Copy link

jmakowski1123 commented Apr 3, 2024

This has product approval, it's part of the larger content tagging initiative which has been ongoing since before product proposal operations were solidified.

@brian-smith-tcril brian-smith-tcril merged commit c9942c1 into openedx:master Apr 3, 2024
7 checks passed
@openedx-webhooks
Copy link

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@xitij2000 xitij2000 deleted the rpenido/fal-3693-add-search-menu-button branch April 4, 2024 10:51
cmltaWt0 pushed a commit to raccoongang/frontend-component-header that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants