fix: href property issue in gatsby build (#580)

* fix: href property issue in gatsby build * chore: improve code coverage
openedx · Oct 13, 2023 · 17876b8 · 17876b8
1 parent a5917c2
commit 17876b8
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 4 deletions.
diff --git a/src/utils.js b/src/utils.js
@@ -138,9 +138,13 @@ export function convertKeyNames(object, nameMap) {
  * @returns {Object}
  */
 export function parseURL(url) {
-  const parser = document?.createElement('a');
-  parser.href = url;
-  return parser;
+  if (typeof document !== 'undefined') {
+    const parser = document.createElement('a');
+    parser.href = url;
+    return parser;
+  }
+
+  return {};
 }
 
 /**
@@ -151,7 +155,7 @@ export function parseURL(url) {
  * @returns {string}
  */
 export function getPath(url) {
-  return parseURL(url).pathname;
+  return typeof document !== 'undefined' ? parseURL(url)?.pathname : '';
 }
 
 /**

diff --git a/src/utils.test.js b/src/utils.test.js
@@ -119,6 +119,16 @@ describe('getQueryParameters', () => {
 describe('ParseURL', () => {
   const testURL = 'http://example.com:3000/pathname/?search=test#hash';
   const parsedURL = parseURL(testURL);
+  let originalDocument;
+
+  beforeEach(() => {
+    originalDocument = global.document;
+  });
+
+  afterEach(() => {
+    global.document = originalDocument;
+  });
+
   it('String URL is correctly parsed', () => {
     expect(parsedURL.toString()).toEqual(testURL);
     expect(parsedURL.href).toEqual(testURL);
@@ -152,6 +162,12 @@ describe('ParseURL', () => {
   it('should return host from URL', () => {
     expect(parsedURL.host).toEqual('example.com:3000');
   });
+
+  it('should return empty object in case of document being undefined', () => {
+    delete global.document;
+
+    expect(parseURL(testURL)).toEqual({});
+  });
 });
 
 describe('getPath', () => {