fix: lint issues in example apps

openedx · Sep 8, 2023 · 1f7f4c7 · 1f7f4c7
1 parent 3b90df8
commit 1f7f4c7
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 8 deletions.
diff --git a/example-plugin-app/.eslintrc.js b/example-plugin-app/.eslintrc.js
@@ -4,7 +4,7 @@ const config = getBaseConfig('eslint');
 
 config.rules = {
   'import/no-extraneous-dependencies': ['error', {
-    'devDependencies': [
+    devDependencies: [
       '**/*.config.js',
       '**/*.test.jsx',
       '**/*.test.js',
@@ -19,7 +19,6 @@ config.rules = {
   }],
   'jsx-a11y/anchor-is-valid': ['error', {
     components: ['Link'],
-    specialLink: [],
     specialLink: ['to'],
     aspects: ['noHref', 'invalidHref', 'preferButton'],
   }],

diff --git a/example-plugin-app/env.config.js b/example-plugin-app/env.config.js
@@ -1,3 +1,4 @@
+// eslint-disable-next-line no-unused-vars
 const config = {
   ACCESS_TOKEN_COOKIE_NAME: 'edx-jwt-cookie-header-payload',
   BASE_URL: 'http://localhost:8081',
@@ -23,4 +24,4 @@ const config = {
   FAVICON_URL: 'https://edx-cdn.org/v3/default/favicon.ico',
   IGNORED_ERROR_REGEX: null,
   PORT: 8081,
-}
+};
diff --git a/example/.eslintrc.js b/example/.eslintrc.js
@@ -4,7 +4,7 @@ const config = getBaseConfig('eslint');
 
 config.rules = {
   'import/no-extraneous-dependencies': ['error', {
-    'devDependencies': [
+    devDependencies: [
       '**/*.config.js',
       '**/*.test.jsx',
       '**/*.test.js',
@@ -19,7 +19,6 @@ config.rules = {
   }],
   'jsx-a11y/anchor-is-valid': ['error', {
     components: ['Link'],
-    specialLink: [],
     specialLink: ['to'],
     aspects: ['noHref', 'invalidHref', 'preferButton'],
   }],

diff --git a/example/src/PluginsPage.jsx b/example/src/PluginsPage.jsx
@@ -19,9 +19,16 @@ export default function PluginsPage() {
         a plugin configuration like the one commented out above in PluginsPage.jsx.
       </p>
       <div className="d-flex flex-column">
-        <PluginSlot id="example" className="d-flex flex-column" pluginProps={{
-          className: 'flex-grow-1'
-        }} style={{ height: 400 }}>
+        <PluginSlot
+          id="example"
+          className="d-flex flex-column"
+          pluginProps={{
+            className: 'flex-grow-1',
+          }}
+          style={{
+            height: 400,
+          }}
+        >
           <div key="default">This is default plugin content.</div>
         </PluginSlot>
       </div>