fix: satisfying the linter

Adjusting dependency arrays and ignoring a ‘forbidden’ prop type warning.
openedx · May 26, 2023 · aa5f8aa · aa5f8aa
1 parent 12abf8b
commit aa5f8aa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/plugins/PluginIframe.jsx b/src/plugins/PluginIframe.jsx
@@ -50,7 +50,7 @@ export default function PluginIframe({
         },
       }, url);
     }
-  }, [iframeElement, mounted, width, height]);
+  }, [iframeElement, mounted, width, height, url]);
 
   usePluginEvent(iframeElement, PLUGIN_MOUNTED, () => {
     setMounted(true);

diff --git a/src/plugins/data/hooks.js b/src/plugins/data/hooks.js
@@ -85,7 +85,7 @@ export function useElementSize() {
 
   const measuredRef = useCallback(_element => {
     setElement(_element);
-  });
+  }, []);
 
   useEffect(() => {
     observerRef.current = new ResizeObserver(() => {

diff --git a/src/plugins/data/shapes.js b/src/plugins/data/shapes.js
@@ -7,5 +7,6 @@ export const pluginShape = PropTypes.shape({
   module: PropTypes.string,
   url: PropTypes.string.isRequired,
   type: PropTypes.oneOf([COMPONENT_PLUGIN, IFRAME_PLUGIN]).isRequired,
-  props: PropTypes.object,
+  // This is a place for us to put any generic props we want to pass to the component.  We need it.
+  props: PropTypes.object, // eslint-disable-line react/forbid-prop-types
 });