-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fallback component as prop for ErrorBoundary #533
feat: fallback component as prop for ErrorBoundary #533
Conversation
Thanks for the pull request, @johnvente! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #533 +/- ##
=======================================
Coverage 83.05% 83.05%
=======================================
Files 40 40
Lines 1062 1062
Branches 194 196 +2
=======================================
Hits 882 882
Misses 168 168
Partials 12 12
☔ View full report in Codecov by Sentry. |
Hi @openedx/fed-bom! Would someone be able to please review/merge this for us? Thanks! |
@johnvente 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
The
ErrorBoundary
component becomes more flexible with the ability to pass the component you want to render in place of just theErrorPage
component. This feature is similar to the react-error-boundary library.Merge checklist:
frontend-platform
. This can be done by runningnpm start
and opening http://localhost:8080.module.config.js
file infrontend-build
.fix
,feat
) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: