-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add plugin framework from old Frontend Platform branch #2
Conversation
9b4eb57
to
384d8a8
Compare
* also includes requirements to integrate the plugin framework in a host/child MFE
384d8a8
to
8718349
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hey @arbrandes, here's the first iteration of getting the frontend plugin framework out of the frontend-platform PR! I'd appreciate any feedback or raised concerns. Once we have this PR in, my team will be working on some bug fixes, metrics, and getting the dependency into Learner Dashboard's main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
Description:
This PR will add the
/plugin
directory from the Frontend Platform PR that the framework was originally built in. Aside from internationalizing strings, this PR is intended to have theThis PR includes:
Upcoming PRs will include:
host-example
andplugin-example
appsreact-error-boundary
with openedx/frontend-platform's ErrorBoundary