Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add plugin framework from old Frontend Platform branch #2

Merged
merged 8 commits into from
Dec 7, 2023

Conversation

jsnwesson
Copy link
Contributor

@jsnwesson jsnwesson commented Nov 7, 2023

Description:
This PR will add the /plugin directory from the Frontend Platform PR that the framework was originally built in. Aside from internationalizing strings, this PR is intended to have the

This PR includes:

  • /plugins directory that is primarily used for the Frontend Plugin Framework
  • updated README to include instructions for use.
  • testing-library dependencies

Upcoming PRs will include:

  • host-example and plugin-example apps
  • replace react-error-boundary with openedx/frontend-platform's ErrorBoundary
  • clean frontend-plugin-framework repo of unnecessary dependencies
  • recent bug fixes, including an iFrame-duplication prevention, that were done during Learner Dashboard POC work.

@jsnwesson jsnwesson force-pushed the jwesson/install-plugins branch 2 times, most recently from 9b4eb57 to 384d8a8 Compare November 8, 2023 00:46
* also includes requirements to integrate the plugin framework in a host/child MFE
@jsnwesson jsnwesson force-pushed the jwesson/install-plugins branch from 384d8a8 to 8718349 Compare November 8, 2023 00:47
Copy link

codecov bot commented Nov 8, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

README.rst Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/plugins/Plugin.jsx Outdated Show resolved Hide resolved
Copy link
Member

@MaxFrank13 MaxFrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsnwesson
Copy link
Contributor Author

Hey @arbrandes, here's the first iteration of getting the frontend plugin framework out of the frontend-platform PR! I'd appreciate any feedback or raised concerns. Once we have this PR in, my team will be working on some bug fixes, metrics, and getting the dependency into Learner Dashboard's main branch.

README.rst Outdated Show resolved Hide resolved
@jsnwesson jsnwesson changed the title build: move plugin framework from frontend-platform into repo build: add plugin framework from old Frontend Platform branch Dec 7, 2023
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@jsnwesson jsnwesson merged commit 527e322 into master Dec 7, 2023
6 of 7 checks passed
@jsnwesson jsnwesson deleted the jwesson/install-plugins branch December 7, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants