Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgraded to node v18, added .nvmrc and updated workflows #556

Merged
merged 7 commits into from
May 16, 2023
Merged

feat: upgraded to node v18, added .nvmrc and updated workflows #556

merged 7 commits into from
May 16, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Mar 15, 2023 •
edited by Mashal-m
Loading

Ticket

Upgrade Node Js from 16 to 18

Description

  • Added support for node v18, updated .nvmrc and workflows.
  • Updated frontend-platform & frontend-build versions
  • With move to node v18 and NPM9, the lockfileVersion is set to 3. Added lockfileversion-check workflow to verify NPM9 is used to generate package-lock file by ensuring lockfileVersion is set to 3

@BilalQamar95 BilalQamar95 self-assigned this Mar 15, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (24ca40f) 0.00% compared to head (ab8e2b7) 0.00%.

Additional details and impacted files 
@@          Coverage Diff           @@
##           master    #556   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           2       2           
  Lines           7       7           
======================================
  Misses          7       7

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review April 10, 2023 07:49
@OmarIthawi OmarIthawi mentioned this pull request Apr 19, 2023
Merged
@Mashal-m Mashal-m marked this pull request as draft April 20, 2023 11:46
@BilalQamar95 BilalQamar95 marked this pull request as ready for review May 10, 2023 11:38
arbrandes
arbrandes approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@arbrandes arbrandes enabled auto-merge May 15, 2023 14:36
@arbrandes
Copy link
Contributor

@BilalQamar95, mind fixing the conflicts?

@arbrandes arbrandes merged commit b029aae into master May 16, 2023
@arbrandes arbrandes deleted the bilalqamar95/node-v18-upgrade branch May 16, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbrandes arbrandes arbrandes approved these changes

Assignees

@BilalQamar95 BilalQamar95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BilalQamar95 @arbrandes