Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Course Search] Trigger Course Search Modal in Course Authoring MFE #199

Closed
bradenmacdonald opened this issue Mar 7, 2024 · 2 comments · Fixed by openedx/frontend-app-authoring#928

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Mar 7, 2024

"As a course author, I want to search for course content in the UI"

Figma designs

Requirements:

  1. Add the 🔍 icon to the Studio header, and show it only if a new ENV variable / feature flag is enabled.
    Screenshot 2024-03-07 at 10 46 29 AM
  2. Clicking the 🔍 icon should open the search modal.
  3. If the user is currently in a course context, the current course ID should be passed to the search modal. If the user is on the "home page" of the course authoring MFE or the taxonomy editor or some other place, no course ID should be passed to the search modal.
  4. Write basic tests. Don't spend any time on tests that cover the search results/filters as those parts of the UI will change.

Notes:

  • Use this prototype PR as a starting point. It contains some TypeScript that needs to be converted to JS though. Remove the keyboard shortcut for opening the modal (for now).
    Screenshot 2024-03-05 at 12 08 06 PM
  • For now, the filters and results and other content of the modal can be as shown ^ in the prototype; implementing the UX for those is in two separate stories.
  • If necessary for dealing with development constraints, coverage requirements, etc. this can be kept as a feature branch until the UX is completed.
@rpenido
Copy link

rpenido commented Mar 26, 2024

Hi @bradenmacdonald! Should we implement this in a view completely contained in the Studio or use an iframe as we did for the ContentTagsDrawer?

@bradenmacdonald
Copy link
Contributor Author

@rpenido This should be 100% in the Course Authoring MFE. When I said "Studio header", I meant the "Course Authoring MFE header".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants