-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feanil/move old stuff #457
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1fbb072
docs: Add a section for obsolete and replaced OEPs.
769f940
feat: Add a way to do redirects.
3b9def3
chore: Complie requirements to add sphinxext-rediraffe.
655cde8
feat: Add the ability redirect to moved files.
6ed85e3
docs: Move less relevant OEPs to an archived section.
5388822
docs: Add redirects for all the files that have been moved.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
name: CI | ||
|
||
on: | ||
push: | ||
branches: [master] | ||
pull_request: | ||
branches: | ||
- '**' | ||
|
||
jobs: | ||
check_for_moved_files: | ||
name: | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
os: [ubuntu-20.04] | ||
python-version: ['3.8'] | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
fetch-depth: 0 | ||
- name: setup python | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Install pip | ||
run: pip install -r requirements/pip.txt | ||
|
||
- name: Install Dependencies | ||
run: pip install -r requirements/base.txt | ||
|
||
- name: Run Rediraffe Check | ||
run: make check_redirects |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,13 +12,19 @@ OEP-5: Pre-built Developer Environments | |
+---------------+----------------------------------------------------+ | ||
| Arbiter | Jesse Zoldak <[email protected]> | | ||
+---------------+----------------------------------------------------+ | ||
| Status | Accepted | | ||
| Status | Replaced | | ||
+---------------+----------------------------------------------------+ | ||
| Type | Architecture | | ||
+---------------+----------------------------------------------------+ | ||
| Created | 2016-06-28 | | ||
+---------------+----------------------------------------------------+ | ||
|
||
.. attention:: | ||
|
||
This OEP has been replaced by | ||
:doc:`/architectural-decisions/oep-0045/decisions/0001-tutor-as-replacement-for-edx-configuration` | ||
a decision made as a part of :doc:`/architectural-decisions/oep-0045-arch-ops-and-config` | ||
|
||
Abstract | ||
******** | ||
|
||
|
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ OEP-7: Migrating to Python 3 | |
+---------------+-----------------------------------------------+ | ||
| Arbiter | Christopher Pappas <[email protected]> | | ||
+---------------+-----------------------------------------------+ | ||
| Status | Accepted | | ||
| Status | Obsolete | | ||
+---------------+-----------------------------------------------+ | ||
| Type | Best Practice | | ||
+---------------+-----------------------------------------------+ | ||
|
@@ -24,6 +24,15 @@ OEP-7: Migrating to Python 3 | |
|
||
.. _open-edx-proposals#21: https://github.com/openedx/open-edx-proposals/pull/21#pullrequestreview-18018383 | ||
|
||
|
||
.. attention:: | ||
|
||
This OEP is Obsolete as all systems within the Open edX platform now run on | ||
Python >= 3.8 | ||
|
||
This OEP served as a coordination point for the upgrade related decisions but | ||
is no longer relevant to the project. | ||
|
||
Abstract | ||
******** | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ OEP-12: Pluggable User Interfaces | |
+---------------+----------------------------------------------------+ | ||
| Arbiter | Clinton Blackburn <[email protected]> | | ||
+---------------+----------------------------------------------------+ | ||
| Status | Accepted | | ||
| Status | Obsolete | | ||
+---------------+----------------------------------------------------+ | ||
| Type | Architecture | | ||
+---------------+----------------------------------------------------+ | ||
|
@@ -23,6 +23,12 @@ OEP-12: Pluggable User Interfaces | |
|
||
.. _open-edx-proposals#34: https://github.com/openedx/open-edx-proposals/pull/34#pullrequestreview-18294926 | ||
|
||
.. attention:: | ||
|
||
This OEP assumes UI components managed by Django however, the Open edX | ||
platform has moved to JS based Micro-Frontends for its user interfaces and | ||
thus the decisions and proposals in this OEP are no longer relevant. | ||
|
||
Abstract | ||
******** | ||
|
||
|
File renamed without changes
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ OEP-25: Incremental Improvements | |
+-----------------+----------------------------------------------------------+ | ||
| Arbiter | Adam Stankiewicz <[email protected]> | | ||
+-----------------+----------------------------------------------------------+ | ||
| Status | Accepted | | ||
| Status | Obsolete | | ||
+-----------------+----------------------------------------------------------+ | ||
| Type | Process | | ||
+-----------------+----------------------------------------------------------+ | ||
|
@@ -25,6 +25,14 @@ OEP-25: Incremental Improvements | |
|
||
.. _Original pull request: https://github.com/openedx/open-edx-proposals/pull/66#pullrequestreview-151034037 | ||
|
||
.. attention:: | ||
|
||
The incremental improvements process is no longer being actively maintained. | ||
If you are looking for places where you can help the project check out issues | ||
tagged as `help wanted | ||
<https://github.com/openedx/public-engineering/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22>` | ||
in the ``public-engineering`` project. | ||
|
||
TL;DR | ||
***** | ||
|
||
|
File renamed without changes.
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ OEP-34: Lint Amnesty | |
+-----------------+--------------------------------------------------------+ | ||
| Arbiter | Usama Sadiq <[email protected]> | | ||
+-----------------+--------------------------------------------------------+ | ||
| Status | Accepted | | ||
| Status | Obsolete | | ||
+-----------------+--------------------------------------------------------+ | ||
| Type | Best Practice | | ||
+-----------------+--------------------------------------------------------+ | ||
|
@@ -22,6 +22,11 @@ OEP-34: Lint Amnesty | |
| `Review Period` | 2019-03-12 - 2021-04-30 | | ||
+-----------------+--------------------------------------------------------+ | ||
|
||
.. attention:: | ||
|
||
This decision was a one time decision and is not relevant to the current | ||
active project. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a related task in openedx/wg-frontend#131 for doing amnesty on eslint warnings which is actively being worked on, but I'm not sure if it's worth keeping the OEP open for that. |
||
|
||
Context | ||
******* | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ OEP-37: Dev Data | |
* - Review Period | ||
- 2019-06-19 to 2019-11-25 | ||
|
||
|
||
Abstract | ||
******** | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
"architectural-decisions/oep-0005-arch-containerize-devstack.rst" "archived/oep-0005-arch-containerize-devstack.rst" | ||
"architectural-decisions/oep-0005/decisions/0001-location-of-decentralized-docs.rst" "archived/oep-0005/decisions/0001-location-of-decentralized-docs.rst" | ||
"architectural-decisions/oep-0005/decisions/0002-why-decentralized-devstack.rst" "archived/oep-0005/decisions/0002-why-decentralized-devstack.rst" | ||
"architectural-decisions/oep-0005/decisions/0003-experiment-with-docker-interface.rst" "archived/oep-0005/decisions/0003-experiment-with-docker-interface.rst" | ||
"architectural-decisions/oep-0005/decisions/0004-data-dump.rst" "archived/oep-0005/decisions/0004-data-dump.rst" | ||
"architectural-decisions/oep-0005/decisions/0005-centralized-devstack.rst" "archived/oep-0005/decisions/0005-centralized-devstack.rst" | ||
"architectural-decisions/oep-0012-arch-fragment-views.rst" "archived/oep-0012-arch-fragment-views.rst" | ||
"best-practices/oep-0007-bp-migrate-to-python3.rst" "archived/oep-0007-bp-migrate-to-python3.rst" | ||
"best-practices/oep-0034-bp-lint-amnesty.rst" "archived/oep-0034-bp-lint-amnesty.rst" | ||
"processes/oep-0025-proc-incremental-improvements.rst" "archived/oep-0025-proc-incremental-improvements.rst" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,4 +4,4 @@ | |
sphinx | ||
sphinx-book-theme | ||
sphinx-copybutton | ||
|
||
sphinxext-rediraffe |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are both of these really the same command? It just returns a different status code when it finds new redirects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
check
one does not write anything but the update_redirects actually writes the changes if it has high enough confidence in them.