feat: Allow pulling translations from a commit hash #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By switching from clone to an explicit init+fetch we can get better control of what commits are fetched. clone only allows targeting a branch or a tag, but fetch can ask for any commit. The caveat is that the server needs to allow this via `uploadpack.allowReachableSHA1InWant` and similar. Minor changes: - checkout is now also quiet by default See openedx#48
timmc-edx
force-pushed
the
timmc/any-commit
branch
from
22928f2 to
8b690ca
Compare
timmc-edx
commented
Dec 21, 2024
Comment on lines
+519
to
+522
| # The `remote.<name>.promisor` config override is needed for git 2.25 and possibly | ||
| # later versions (but not in 2.30 and later). In some earlier versions it might | ||
| # instead need to be written as `extensions.partialClone=origin` -- 2.25.1 mentions | ||
| # this in its output if a promisor is not set, but doesn't actually *use* that config. |
There was a problem hiding this comment.
Some info on this inconsistency: https://lore.kernel.org/git/[email protected]/T/
This was referenced Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By switching from clone to an explicit init+fetch we can get better control of what commits are fetched. clone only allows targeting a branch or a tag, but fetch can ask for any commit. The caveat is that the server needs to allow this via
uploadpack.allowReachableSHA1InWantand similar.Minor changes:
For testing, I entered the edx-platform repo and made calls like the following:
In between tests I cleared state with
rm -rf conf/locale/ conf/plugins-locale/ translations_TEMP/; git checkout conf/.I didn't check translations files directly, but I did use
du -bs .to confirm that the published atlas and my patched version caused the same increase in total file size in the repo, which seemed like a good proxy.