Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct event type for forum events #437

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions openedx_events/learning/signals.py
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@
# .. event_data: DiscussionThreadData
# .. event_warning: This event is currently incompatible with the event bus, list/dict cannot be serialized yet
FORUM_THREAD_CREATED = OpenEdxPublicSignal(
event_type="org.openedx.learning.thread.created.v1",
event_type="org.openedx.learning.forum.thread.created.v1",
data={
"thread": DiscussionThreadData,
}
Expand All @@ -309,7 +309,7 @@
# .. event_data: DiscussionThreadData
# .. event_warning: This event is currently incompatible with the event bus, list/dict cannot be serialized yet
FORUM_THREAD_RESPONSE_CREATED = OpenEdxPublicSignal(
event_type="org.openedx.learning.response.created.v1",
event_type="org.openedx.learning.forum.thread.response.created.v1",
data={
"thread": DiscussionThreadData,
}
Expand All @@ -321,7 +321,7 @@
# .. event_data: DiscussionThreadData
# .. event_warning: This event is currently incompatible with the event bus, list/dict cannot be serialized yet
FORUM_RESPONSE_COMMENT_CREATED = OpenEdxPublicSignal(
event_type="org.openedx.learning.response.created.v1",
event_type="org.openedx.learning.forum.thread.response.comment.created.v1",
data={
"thread": DiscussionThreadData,
}
Expand Down
6 changes: 3 additions & 3 deletions openedx_events/tooling.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
"org.openedx.content_authoring.course.certificate_config.changed.v1",
"org.openedx.content_authoring.course.certificate_config.deleted.v1",
"org.openedx.learning.user.notification.requested.v1",
"org.openedx.learning.thread.created.v1",
"org.openedx.learning.response.created.v1",
"org.openedx.learning.comment.created.v1",
"org.openedx.learning.forum.thread.created.v1",
"org.openedx.learning.forum.thread.response.created.v1",
"org.openedx.learning.forum.thread.response.comment.created.v1",
"org.openedx.learning.course.notification.requested.v1",
"org.openedx.learning.ora.submission.created.v1",
]
Expand Down
Loading