-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python API to get tag counts, ignore deleted/disabled ObjectTags by default [FC-0036] #115
Conversation
Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
1 similar comment
Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
FYI @ChrisChV since you mentioned the issue with deleted/disabled object tags being included in the APIs - I fixed it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks fine, thanks @bradenmacdonald !
But I think this needs a version bump?
- I tested this using django runserver, hit the modified APIs
- I read through the code
-
I checked for accessibility issuesN/A - Includes documentation
-
User-facing strings are extracted for translationN/A
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR:
get_object_tag_counts
API available via python as well as REST. Previously it was REST-only.get_object_tags
andget_object_tag_counts
APIs ignore tags from deleted or disabled taxonomies by default. Anything else would be confusing for users. Keep in mind, we do preserve the underlying ObjectTag data; we just don't want to display it.This is for openedx/modular-learning#118 part 1b.
Private ref: FAL-3564.