Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tags count to taxonomy serializer [FC-0036] #125

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Nov 29, 2023

Testing instructions

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 29, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ChrisChV ChrisChV changed the title feat: Add tags count to taxonomy serializer feat: Add tags count to taxonomy serializer [FC-0036] Nov 29, 2023
@bradenmacdonald
Copy link
Contributor

@ChrisChV Please add a test that verifies this field is included in the REST API response(s)

@ChrisChV
Copy link
Contributor Author

Please add a test that verifies this field is included in the REST API response(s)

@bradenmacdonald Sure. Added here 503bd0d

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: confirmed the count is in the API response
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a

@bradenmacdonald bradenmacdonald merged commit 06f4f54 into openedx:main Nov 30, 2023
7 checks passed
@bradenmacdonald bradenmacdonald deleted the chris/tags-count-taxonomy branch November 30, 2023 22:10
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants