Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create_next_version -> create_next_component_version #215

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

ormsbee
Copy link
Contributor

@ormsbee ormsbee commented Aug 19, 2024

Since the authoring apps now have their APIs aggregated into the public openedx_learning.api.authoring module, create_next_version will be ambiguous as soon as we create other versioned things like Units.

I'm including an alias to give more flexibility for switching edx-platform over.

Since the authoring apps now have their APIs aggregated into the public
openedx_learning.api.authoring module, "create_next_version" will be
ambiguous as soon as we create other versioned things like Units.

I'm including an alias to give more flexibility for switching
edx-platform over.
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the micro-nit that I'd call this a non-breaking feat: since it changes the public API

@ormsbee
Copy link
Contributor Author

ormsbee commented Aug 20, 2024

@kdmccormick: Ah, good point. I'll change the commit message.

@ormsbee ormsbee merged commit 1ebc212 into openedx:main Aug 20, 2024
9 checks passed
@ormsbee ormsbee deleted the ambiguous-api-call-fix branch August 20, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants