-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ecommerce to the translation pipeline #2181
feat: Add ecommerce to the translation pipeline #2181
Conversation
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
ce16f98
to
fab818f
Compare
Refs: FC-0012 OEP-58
fab818f
to
0aec531
Compare
Ready for review @OmarIthawi @brian-smith-tcril |
@@ -214,7 +215,8 @@ jobs: | |||
cd translations/${{ matrix.repo }} | |||
# finds the directory containing the english locale usually located in | |||
# */*/conf/locale/en | |||
EN_DIR=$(find . -type d -regex ".+conf\/locale\/en$") | |||
# but also exclude any hidden directories that might exist for some reason | |||
EN_DIR=$(find . -type d -not -path '*/.*' -regex ".+conf\/locale\/en$") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ecommerce uses tox
for all of its make commands. This will exclude .tox
contents (instead of refactoring the Makefile)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shadinaif! Looks good!
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
feat: Add ecommerce to the translation pipeline
Refs:
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
see details here