Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ecommerce to the translation pipeline #2181

Merged

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Nov 13, 2023

feat: Add ecommerce to the translation pipeline

Refs:
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
see details here

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 13, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 13, 2023

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks
Copy link

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.ecommerce branch 2 times, most recently from ce16f98 to fab818f Compare November 13, 2023 12:38
@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.ecommerce branch from fab818f to 0aec531 Compare November 14, 2023 06:11
@shadinaif shadinaif marked this pull request as ready for review November 14, 2023 06:20
@shadinaif
Copy link
Contributor Author

Ready for review @OmarIthawi @brian-smith-tcril

@@ -214,7 +215,8 @@ jobs:
cd translations/${{ matrix.repo }}
# finds the directory containing the english locale usually located in
# */*/conf/locale/en
EN_DIR=$(find . -type d -regex ".+conf\/locale\/en$")
# but also exclude any hidden directories that might exist for some reason
EN_DIR=$(find . -type d -not -path '*/.*' -regex ".+conf\/locale\/en$")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ecommerce uses tox for all of its make commands. This will exclude .tox contents (instead of refactoring the Makefile)

Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shadinaif! Looks good!

@OmarIthawi OmarIthawi merged commit c33c7ca into openedx:main Nov 14, 2023
4 checks passed
@openedx-webhooks
Copy link

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@OmarIthawi OmarIthawi deleted the shadinaif/FC-0012-OEP-58.ecommerce branch November 14, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants