Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ecommerce to the translation pipeline #2181

Merged
merged 1 commit into from
Nov 14, 2023
Merged

feat: Add ecommerce to the translation pipeline #2181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/extract-translation-source-files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ jobs:
'credentials',
'credentials-themes',
'DoneXBlock',
'ecommerce',
'edx-ace',
'edx-bulk-grades',
'edx-ora2',
Expand Down Expand Up @@ -214,7 +215,8 @@ jobs:
cd translations/${{ matrix.repo }}
# finds the directory containing the english locale usually located in
# */*/conf/locale/en
EN_DIR=$(find . -type d -regex ".+conf\/locale\/en$")
# but also exclude any hidden directories that might exist for some reason
EN_DIR=$(find . -type d -not -path '*/.*' -regex ".+conf\/locale\/en$")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ecommerce uses tox for all of its make commands. This will exclude .tox contents (instead of refactoring the Makefile)

# If the directory is not found, exit with an error. This can happen if we add a repository that doesn't
# comply with OEP-58, or it still doesn't have any translations yet
if [ -z "$EN_DIR" ]; then
Expand Down