Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require the validation comment on non-fork PRs #1930

Merged
merged 1 commit into from
Oct 20, 2023
Merged

feat: require the validation comment on non-fork PRs #1930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/validate-translation-files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,10 @@ jobs:

exit $has_validation_errors

# Due to GitHub Actions security reasons this will not work on fork pull requests.
# This shouldn't be an issue, because bots writes directly to this repository.
- name: Post translation validation results as a comment
if: always()
continue-on-error: true # Don't fail the build if posting the comment fails on fork pull requests.
# Due to GitHub Actions security reasons posting a comment isn't possible on fork pull requests.
# This shouldn't be an issue, because bots writes directly to this repository.
if: ${{ always() && !github.event.pull_request.head.repo.fork }}
uses: mshick/add-pr-comment@7c0890544fb33b0bdd2e59467fbacb62e028a096
with:
message: |
Expand Down