fix: avoid overriding manual edits for newer entries #2177
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
OmarIthawi
force-pushed
the
sync_no_override
branch
from
9d41f4b to
d5fed36
Compare
|
Status: I'll pause working on this pull request until we're done with the edx platform backend work. |
| @@ -44,10 +44,6 @@ jobs: | |||
| old_slug: course_discovery | |||
| old_project_slug: edx-platform | |||
|
|
|||
| - new_slug: course-discovery | |||
| @@ -181,7 +217,7 @@ def run_from_workflow_yaml_file(self, workflow_configs): | |||
| """ | |||
| Run the script from a GitHub Actions migrate-from-transifex-old-project.yml workflow file. | |||
| """ | |||
| pairs_list = workflow_configs['jobs']['migrate-translations']['strategy']['matrix']['batch'] | |||
| pairs_list = workflow_configs['jobs']['migrate-translations']['strategy']['matrix']['resource'] | |||
There was a problem hiding this comment.
the key name has changed, the sync is broken otherwise due to KeyError
| if __name__ == '__main__': | ||
| command = Command(sys.argv, environ=os.environ, tx_api=transifex_api) | ||
| def main(): # pragma: no cover | ||
| parser = argparse.ArgumentParser(description=__doc__) |
There was a problem hiding this comment.
Added argparse to protect against argv typos.
OmarIthawi
force-pushed
the
sync_no_override
branch
2 times, most recently
from
8209b9c to
537b62c
Compare
OmarIthawi
force-pushed
the
sync_no_override
branch
from
537b62c to
39975db
Compare
OmarIthawi
force-pushed
the
sync_no_override
branch
from
39975db to
bd896e1
Compare
|
@brian-smith-tcril @shadinaif this pull request is now ready for review. |
| current_translation_time = parse_tx_date(current_translation.datetime_translated) | ||
|
|
||
| if old_project_translation_time and current_translation_time: | ||
| newer_translation_found = current_translation_time > old_project_translation_time |
There was a problem hiding this comment.
This is the gist of the pull request.
|
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Problem
We've done about 200 manual fix on the https://app.transifex.com/open-edx/openedx-translations/ to fix translation validation issues in PRs such as d1ddaa7.
Those changes would be overridden on the next sync and needs to be fixed again.
For more information, please check this Slack Thread about the problem.
Solution
This pull request will only update the translation string if new translation is found:
TODO
$ make SYNC_ARGS=--dry-run TX_NEW_SLUG=course-discovery TX_OLD_SLUG=course_discovery TX_OLD_PROJECT_SLUG=edx-platform TX_LANGUAGES=es_419 sync_translationsThis pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.