fix: revert: avoid failing the automerge-transifex-app-prs.yml #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 854ceef. There has been new failures which prevented such as: > GraphQL: Pull request Pull request is in unstable status (enablePullRequestAutoMerge) as well as the interminent error of: > auto-merge was automatically disabled yesterday > Base branch was modified This effectively brings back both openedx#222 and openedx#225
increase retry_wait_seconds to 180
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
use bash if-statement to check for null instead of throwing JavaScript after attempting to parse a null date.
|
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 854ceef, but increase
retry_wait_secondsto 180 and use bash if-statement.There has been new failures which prevented such as:
as well as the interminent error of:
This effectively brings back both #222 and #225.
Refs
This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.