feat: Enabled translations for frontend-app-learner-portal-enterprise #3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.gitignore
Outdated
Comment on lines
10
to
11
| # IntelliJ IDE files | ||
| .idea/ |
There was a problem hiding this comment.
This is probably a good thing to add to the .gitignore file, but it's unrelated to this PR. Would you mind making a new PR with just this change and removing it from this one?
|
You mentioned
Would you mind adding a link to the PR that added those (or a link to the lines in the file) to the description on this PR so it can be easily cross-referenced? |
|
@brian-smith-tcril Can you take another look? I have made the changes you suggested above. |
brian-smith-tcril
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: ENT-8221
Description:
This PR enables translations for
frontend-app-learner-portal-enterpriserepo. The required commands have already been added to theMakefileoffrontend-app-learner-portal-enterprise(https://github.com/openedx/frontend-app-learner-portal-enterprise/blob/master/Makefile#L44-L67).Note: I was not able to test this via the instructions in https://docs.openedx.org/en/latest/developers/how-tos/enable-translations-new-repo.html#id7 However, I have tested the flow using my own Transifex account.