-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Special support for XBlocks #593
feat: Special support for XBlocks #593
Conversation
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
a584dd8
to
b4e34f0
Compare
This is ready @OmarIthawi @brian-smith-tcril |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, I'll wait to see if @OmarIthawi has any feedback before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shadinaif I agree with the overall process. However, the implementation is becoming a bit cumbersome.
Nevertheless, I think we should refactor this file eventually. Therefore, I've added an issue for that:
XBlocks require text.po and textjs.po instead of django.po and djangojs.po Refs: FC-0012 OEP-58
b4e34f0
to
0fa68f0
Compare
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
feat: Special support for XBlocks
XBlocks require
text.po
andtextjs.po
instead ofdjango.po
anddjangojs.po
. This PR will add support to find XBlock translation files and rename them todjango
during translation extraction.Why is this needed?
After moving along with standardizing
make extract_translations
in XBlocks; we found that it's safer to keeptext.po
andtextjs.po
as the translation domains for XBlocks. It's to preserve compatibility with in-repo translations since it'll be used for a while by the communitySee this related conversation openedx/edx-cookiecutters#382 (comment)
text.po
as the domain for translation https://github.com/Zeit-Labs/xblock-drag-and-drop-v2/blob/9956abde00175e3d53dff53502b10fafbd6af0d3/Makefile#L12