Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Superset link text, make the link optional #51

Merged
merged 3 commits into from
May 16, 2024

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented May 15, 2024

Closes openedx/tutor-contrib-aspects#814

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@bmtcril bmtcril marked this pull request as draft May 15, 2024 18:16
@bmtcril
Copy link
Contributor Author

bmtcril commented May 15, 2024

This is in draft as I haven't tested the changes yet.

Copy link

github-actions bot commented May 15, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  platform_plugin_aspects
  __init__.py
  platform_plugin_aspects/extensions
  filters.py 42-43
Project Total  

This report was generated by python-coverage-comment-action

@bmtcril
Copy link
Contributor Author

bmtcril commented May 16, 2024

I was able to test, this should be good to review now

@bmtcril bmtcril marked this pull request as ready for review May 16, 2024 12:39
@bmtcril bmtcril requested review from Ian2012 and pomegranited May 16, 2024 12:39
}

print(section_data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Print statement

@Ian2012 Ian2012 merged commit 818d383 into main May 16, 2024
10 checks passed
@Ian2012 Ian2012 deleted the bmtcril/superset_link_updates branch May 16, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise text on link to Superset and make it possible to hide
2 participants