Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: major version updated for frontend-platform, paragon & frontend-build #20

Conversation

BilalQamar95
Copy link
Contributor

Description:

  • Updated major versions for frontend-platform, paragon & frontend-build

@BilalQamar95 BilalQamar95 self-assigned this Jan 24, 2024
@BilalQamar95 BilalQamar95 requested a review from feanil January 24, 2024 11:36
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a03b3a) 87.03% compared to head (7ea73fb) 87.03%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   87.03%   87.03%           
=======================================
  Files           7        7           
  Lines          54       54           
  Branches        5        5           
=======================================
  Hits           47       47           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"@edx/frontend-platform": "4.6.0",
"@edx/paragon": "^20.44.0",
"@edx/frontend-platform": "6.2.0",
"@edx/paragon": "21.5.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paragon has moved to the openedx scope (@openedx/paragon). Version 21.5.7 is the same content as 21.5.6 of @edx/paragon

To do this bump, you'll need to update to the new scope and update any imports of paragon to point to the new location.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a PR already open for it, once merged I will rebase

@@ -45,7 +45,7 @@
},
"devDependencies": {
"@edx/browserslist-config": "^1.1.1",
"@edx/frontend-build": "12.8.38",
"@edx/frontend-build": "13.0.14",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with paragon, frontend-build has also moved to the openedx scope (@openedx/frontend-build), Version 13.0.15 there should be the same as this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a PR already open for it, once merged I will rebase

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think this PR can be closed in favor of #21 since it updates all the libraries being updated here.

@brian-smith-tcril
Copy link
Contributor

I'm closing this one since the changes in it have been covered by #21

If there is something that I missed in #21 please let me know! I'd be happy to make a follow up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants