feat: modify queryset from prefetch to select related #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-3860
This PR modifies prefetch queryset to select_related query to reduce db round-trip for a skill fetching.
Testing:
edx/src
directory.Course Skills
to courses via discovery admin.modify-queryset
and hit the endpoint again. Note the decrease in query count.search/all
endpoint with 2 scenarios:Course with multiple skills -> (with no skill_category and skill_subcategory)
Courses with multiple skill -> (having skill_category and skill_subcategory)
Merge checklist:
requirements/*.txt
files)make upgrade && make requirements
have been run to regenerate requirements./manage.py makemigrations
has been runPost merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgrade
in course-discovery will look for the latest version in PyPi.