Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add course name to run charts #1019

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

saraburns1
Copy link
Contributor

Closes openedx/openedx-aspects#301
Also added Org to the same charts on the 'Course Metrics' tab

image
image
image
image

@saraburns1 saraburns1 requested a review from bmtcril February 3, 2025 17:45
@bmtcril
Copy link
Contributor

bmtcril commented Feb 3, 2025

Have you checked how these look with a real (long) course name / org? Just want to make sure it doesn't break UI

@saraburns1
Copy link
Contributor Author

Squishes the graph a bit but I think it still looks fine
image

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saraburns1 saraburns1 merged commit a31c4b4 into openedx:main Feb 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add course name to tables and charts without them on the Run Metrics tab of the Course Comparison Dashboard
2 participants