Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Tidy up Operator Dashboard #445

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Oct 3, 2023

Closes: #380

  • Make names consistent
  • Remove unusable or useless charts
  • Add a "slowest ClickHouse queries" chart
  • Remove the Course Success and Learner Engagement tabs which just had "coming soon" text

Before screenshots:

Screenshot 2023-10-03 at 3 26 32 PM
Screenshot 2023-10-03 at 3 26 11 PM

After screenshots:

Screenshot 2023-10-03 at 3 29 20 PM
Screenshot 2023-10-03 at 3 28 58 PM

@bmtcril bmtcril requested a review from Ian2012 October 3, 2023 19:08
@Ian2012
Copy link
Contributor

Ian2012 commented Oct 3, 2023

@bmtcril can you leave screenshots of the changes?

@bmtcril
Copy link
Contributor Author

bmtcril commented Oct 3, 2023

@Ian2012 all set

@Ian2012
Copy link
Contributor

Ian2012 commented Oct 3, 2023

@bmtcril the k8s jobs are failing. Can you move the translations file to a different folder, create a configmap for it, and attach it to superset?

@bmtcril
Copy link
Contributor Author

bmtcril commented Oct 3, 2023

@Ian2012 probably not today, I'll have to take a look next week

- Make names consistent
- Remove unusable or useless charts
- Add a "slowest ClickHouse queries" chart
Hopefully will fix k8s build issues around the size of the pythonpath
configmap.
@bmtcril bmtcril force-pushed the bmtcril/tidy_operator_dash branch from 7c83270 to e93a095 Compare October 10, 2023 19:50
- plugins/{{ file }}{% endfor %}
options:
labels:
app.kubernetes.io/name: superset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update label superset-localization

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The others around it are labeled this way, should they be changed as well?

Copy link
Contributor

@Ian2012 Ian2012 Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry, I was confused with this label. The label shows that those config maps are related to the superset aplication

@Ian2012
Copy link
Contributor

Ian2012 commented Oct 10, 2023

@bmtcril can you upgrade the tutor version to 16.1.3

More context here: https://discuss.openedx.org/t/missing-py2neo-package-causing-build-issues-in-all-edx-platform-releases/11371

@bmtcril bmtcril force-pushed the bmtcril/tidy_operator_dash branch 2 times, most recently from 22aa247 to 770ce38 Compare October 10, 2023 21:12
@bmtcril bmtcril merged commit b7ba403 into main Oct 10, 2023
10 checks passed
@bmtcril bmtcril deleted the bmtcril/tidy_operator_dash branch October 10, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Operator dashboard usability pass
2 participants