Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create embeddable UUID #463

Merged
merged 6 commits into from
Oct 13, 2023
Merged

feat: create embeddable UUID #463

merged 6 commits into from
Oct 13, 2023

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Oct 13, 2023

Description

This PR fixes #448

This PR generate idempotent embeddable UUIDs for the dashboards, the UUID used is the same as the dashboard UUID

@Ian2012 Ian2012 requested a review from bmtcril October 13, 2023 17:21
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 13, 2023
@Ian2012 Ian2012 force-pushed the cag/embedded_uuids branch from d8b2a74 to dc98040 Compare October 13, 2023 18:32
bmtcril
bmtcril approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this makes a lot more sense to me, thanks! I have a fix for the tests running out of disks in #462

@Ian2012 Ian2012 force-pushed the cag/embedded_uuids branch from dc98040 to 7e4b6fd Compare October 13, 2023 19:04
@Ian2012
Copy link
Contributor Author

Ian2012 commented Oct 13, 2023

@bmtcril cherry-picking your commit for CI to pass

@Ian2012 Ian2012 force-pushed the cag/embedded_uuids branch 5 times, most recently from 3743edb to e08e24a Compare October 13, 2023 20:33
@Ian2012 Ian2012 mentioned this pull request Oct 13, 2023
Merged
7 tasks
bmtcril
bmtcril reviewed Oct 13, 2023
View reviewed changes
tutoraspects/plugin.py Outdated
("SUPERSET_ADMIN_EMAIL", "[email protected]"),
("SUPERSET_LMS_EMAIL", "[email protected]"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking that we should probably change these to invalid email addresses by default so no one gets accidentally emailed private questions about sites. Asking around Axim right now for ideas.

Copy link
Contributor Author

@Ian2012 Ian2012 Oct 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update the default to be lms-admin@{{lms_host}}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just go with superset/[email protected] since it will never resolve and cause errors if anyone tries to use it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready

@Ian2012 Ian2012 force-pushed the cag/embedded_uuids branch from e08e24a to cef50fd Compare October 13, 2023 20:51
@Ian2012 Ian2012 merged commit c6b95df into main Oct 13, 2023
5 checks passed
@Ian2012 Ian2012 deleted the cag/embedded_uuids branch October 13, 2023 23:12
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmtcril bmtcril bmtcril approved these changes

Assignees
No one assigned
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate embedable UUID for dashboards
4 participants
@Ian2012 @openedx-webhooks @bmtcril @itsjeyd