Fix problem responses, bump ERB #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SoryRawyer this, combined with the upstream fix in ERB, should fix the problem responses issues we were seeing if you'd like to take a look. |
Ian2012
approved these changes
Nov 8, 2023
Ian2012
reviewed
Nov 8, 2023
The new version of ERB makes user responses to problems parsable as JSON, allowing our reports to work correctly. This PR updates the ERB version and updates downstream models to parse the values correctly.
The requirement may not be versioned this way, for instance it breaks tutor init when using a git hash or branch for testing.
bmtcril
force-pushed
the
bmtcril/erb_7_0_1
branch
from
73749c0 to
24dc754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERB would previously (accidentally) send response values that were intended to be JSON lists as repr's of Python objects. In some cases that would render them unable to be parsed downstream (especially in SQL, though we tried). This uses the new ERB and cleans up our implementation to use the JSON lists if present.