-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to host dbt docs on cluster #892
Conversation
Thanks for the pull request, @Ian2012! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hey @bmtcril and @pomegranited, would you have time to give this PR a look? |
There are a couple of issues with this refactor:
|
Seems a little closer, I can init now, but k8s complains about the format of the deployment:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the code is in a good place! Can you document the new feature and setting, why people might want it, and why they should be careful about turning it on / what access controls people might want? A "how-to" in openedx-aspects is probably the best place for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in k8s and local and is working well
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR allows hosting dbt docs locally and on k8s. It also stores the
manifest.json
state file and superset exposures in clickhouse enabling us to remove the volume for the state. Closes: #915Testing instructions
RUN_ASPECTS_DOCS
in yourconfig.yml
.tutor dev do alembic -c "upgrade head"
tutor images build aspects