Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: repo maintenance #109

Merged
merged 9 commits into from
Jan 18, 2024

Conversation

Agrendalath
Copy link
Member

@Agrendalath Agrendalath commented Jan 17, 2024

This:

  1. Adds catalog-info.yaml.
  2. Updates .gitignore.
  3. Removes some leftover code from Python 2.
  4. Modernizes building the package.
  5. Modernizes running test.
  6. Removes unused integration tests.
  7. Updates requirements.
  8. Adds automatic Python requirement upgrades.
  9. Adds the CI workflow to upload the package to PyPI.
  10. Improves CI scripts.

@Agrendalath Agrendalath self-assigned this Jan 17, 2024
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 17, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 17, 2024

Thanks for the pull request, @Agrendalath! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Agrendalath Agrendalath marked this pull request as ready for review January 17, 2024 03:09
@Agrendalath Agrendalath force-pushed the agrendalath/maintenance branch 2 times, most recently from 62a419a to 7c8bf45 Compare January 17, 2024 03:16
@Agrendalath Agrendalath force-pushed the agrendalath/maintenance branch from 7c8bf45 to a86bcd8 Compare January 17, 2024 03:18
@Agrendalath Agrendalath force-pushed the agrendalath/maintenance branch from a86bcd8 to 9ff18b2 Compare January 17, 2024 16:47
@Agrendalath
Copy link
Member Author

@feanil, would you mind reviewing this? I tried to make the git history easy to follow.

@Agrendalath Agrendalath requested a review from feanil January 17, 2024 16:49
@feanil
Copy link
Contributor

feanil commented Jan 17, 2024

Yes, I'll take a look tomorrow.

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @Agrendalath , the changes all look good to me!

.github/workflows/pypi-publish.yml Show resolved Hide resolved
@Agrendalath Agrendalath merged commit d083b8c into openedx:master Jan 18, 2024
6 checks passed
@openedx-webhooks
Copy link

@Agrendalath 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Agrendalath Agrendalath deleted the agrendalath/maintenance branch January 18, 2024 14:39
@Agrendalath
Copy link
Member Author

@feanil, the CI fails to create a git tree in this repo (and in the openedx/xblock-google-drive). Are some additional permissions required for the requirements bot?

@feanil
Copy link
Contributor

feanil commented Jan 23, 2024

Yes, there was a team that needed to be added, I've done so and verified that it is fixed.

https://github.com/openedx/xblock-image-explorer/actions/runs/7631295800/job/20788929574

setup.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants