Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Structure for supporting multiple XBlocks #2

Merged
merged 25 commits into from
Oct 7, 2024
Merged

Core Structure for supporting multiple XBlocks #2

merged 25 commits into from
Oct 7, 2024

Conversation

irtazaakram
Copy link
Member

@irtazaakram irtazaakram commented Jul 8, 2024 •
edited
Loading

Things to figure out:

farhan
farhan requested changes Jul 8, 2024
View reviewed changes
xblocks_contrib/annotatable/annotatable.py Outdated Show resolved Hide resolved
requirements/base.in Outdated Show resolved Hide resolved
requirements/base.in Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
tests/test_annotatable.py Outdated Show resolved Hide resolved
xblocks_contrib/annotatable/annotatable.py Outdated Show resolved Hide resolved
xblocks_contrib/annotatable/annotatable.py Outdated Show resolved Hide resolved
xblocks_contrib/annotatable/annotatable.py Outdated Show resolved Hide resolved
xblocks_contrib/annotatable/annotatable.py Show resolved Hide resolved
manage.py Outdated Show resolved Hide resolved
farhan
farhan requested changes Jul 15, 2024
View reviewed changes
utils/create_xblock.sh Outdated Show resolved Hide resolved
utils/create_xblock.sh Outdated Show resolved Hide resolved
@irtazaakram irtazaakram changed the title chore: initial commit Core Structure for supporting multiple XBlocks Jul 24, 2024
farhan
farhan reviewed Jul 24, 2024
View reviewed changes
utils/create_xblock.sh Outdated Show resolved Hide resolved
@farhan farhan mentioned this pull request Aug 7, 2024
Open
kdmccormick
kdmccormick requested changes Aug 12, 2024
View reviewed changes
xblocks_contrib/poll/poll.py Outdated Show resolved Hide resolved
@kdmccormick kdmccormick self-requested a review August 13, 2024 12:44
kdmccormick
kdmccormick requested changes Aug 13, 2024
View reviewed changes
docs/decisions/0001-purpose-of-this-repo.rst Show resolved Hide resolved
catalog-info.yaml Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
xblocks_contrib/poll/poll.py Outdated Show resolved Hide resolved
xblocks_contrib/poll/translation Outdated Show resolved Hide resolved
xblocks_contrib/poll/static/README.txt Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
@kdmccormick kdmccormick mentioned this pull request Sep 4, 2024
Open
@kdmccormick
Copy link
Member

As we discussed in our last sync-up, please add stub blocks for all builtin component blocks:
PollBlock
WordCloudBlock
AnnotatableBlock
LtiBlock
HtmlBlock
DiscussionBlock
ProblemBLock
VideoBlock

Doing that will unblock openedx/edx-platform#35308

Let me know if you are run into any issues or need any pointers.

@irtazaakram
Copy link
Member Author

Hi @kdmccormick,

Done with the stub blocks for all specified xblocks—please review when you can. Thanks!

@kdmccormick kdmccormick self-requested a review September 16, 2024 14:29
kdmccormick
kdmccormick approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestion, but otherwise, looks great!

setup.py Outdated Show resolved Hide resolved
docs/decisions/0001-purpose-of-this-repo.rst Outdated Show resolved Hide resolved
docs/decisions/0001-purpose-of-this-repo.rst Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
farhan
farhan reviewed Sep 24, 2024
View reviewed changes
requirements/ci.in Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@farhan
Copy link

farhan commented Oct 3, 2024

I think we should add is_extracted = True field to extracted xblocks in this PR as mentioned here

@farhan
Copy link

farhan commented Oct 3, 2024

Screenshot 2024-10-03 at 4 11 18 PM

It will be great if could run the migrations within dev.run command

farhan
farhan requested changes Oct 3, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
requirements/dev.in Show resolved Hide resolved
tests/test_annotatable.py Outdated Show resolved Hide resolved
utils/create_xblock.sh Outdated Show resolved Hide resolved
farhan
farhan requested changes Oct 7, 2024
View reviewed changes
xblocks_contrib/annotatable/annotatable.py Outdated Show resolved Hide resolved
farhan
farhan approved these changes Oct 7, 2024
View reviewed changes
Copy link

@farhan farhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 🌟

@irtazaakram irtazaakram merged commit 6c2384a into main Oct 7, 2024
11 of 12 checks passed
@irtazaakram irtazaakram deleted the core-xblocks branch October 7, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhan farhan farhan approved these changes

@kdmccormick kdmccormick kdmccormick approved these changes

@feanil feanil Awaiting requested review from feanil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irtazaakram @kdmccormick @farhan