-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database Imports Not Working & SSH Tunnel Limitations #451
Draft
khelfen
wants to merge
21
commits into
dev
Choose a base branch
from
bug/#450-bug-database-imports-not-working-ssh-tunnel-limitations
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Database Imports Not Working & SSH Tunnel Limitations #451
khelfen
wants to merge
21
commits into
dev
from
bug/#450-bug-database-imports-not-working-ssh-tunnel-limitations
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OEP_TOKEN environment variable
…OEP_TOKEN environment variable
…to feature/use_TOEP_token
…tunnel internally
- Check if the database host contains 'toep' by examining engine.url.host. - If connected to a TOEP database, apply logic to translate table names accordingly.
Add GNU license URL to linkcheck ignore list
…to feature/use_TOEP_token
…h improved handling for default token file and format validation
- Add `TOEP_TOKEN.*` to `.gitignore` to prevent accidental commits of sensitive tokens. - Improve token retrieval logic in `edisgo/io/db.py`: - Use `importlib.util.find_spec` to locate the `edisgo` package directory dynamically. - Check for token existence before reading to avoid `FileNotFoundError`. - Improve logging for missing or invalid tokens, providing clearer warnings about potential connection issues. - Ensure a more robust fallback mechanism when no valid token is found.
…rts-not-working-ssh-tunnel-limitations
- Replaced direct use of copy.deepcopy with custom copy method in two places. - Added a new `copy` method to the `EDisGo` class, supporting both shallow and deep copies while excluding the SQLAlchemy engine from being copied. - Ensured proper restoration of the SQLAlchemy engine after copying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed.
Fixes #450 and #455
Type of change
Please delete options that are not relevant.
Checklist:
pre-commit
hooksNew and adjusted code includes type hinting nowI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksIf new packages are needed, I added them the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.