Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing timeindex in set_time_series_active_power_predefined #457

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

khelfen
Copy link
Collaborator

@khelfen khelfen commented Feb 17, 2025

Description

  • Automatically set EDisGo.TimeSeries.timeindex to the default year of the database if it is empty.
  • Added a logger warning to inform users about the default behavior and recommend setting the timeindex explicitly using EDisGo.set_timeindex().

Fixes #456

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • New and adjusted code is formatted using the pre-commit hooks
  • New and adjusted code includes type hinting now
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The Read the Docs documentation is compiling correctly
  • If new packages are needed, I added them the setup.py, and if needed the rtd_requirements.txt, the eDisGo_env.yml and the eDisGo_env_dev.yml.
  • I have added new features to the corresponding whatsnew file

- Automatically set `EDisGo.TimeSeries.timeindex` to the default year of the database if it is empty.  # - Added a logger warning to inform users about the default behavior and recommend setting the `timeindex` explicitly using
`EDisGo.set_timeindex()`.  # On branch feature/#456-feature-set-default-timeindex-in-edisgoset_time_series_active_power_predefined
@khelfen khelfen requested a review from joda9 February 17, 2025 11:04
@khelfen khelfen self-assigned this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Set Default timeindex in edisgo.set_time_series_active_power_predefined
2 participants