python3-pybind11: Remove the Boost dependency #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boost is an optional dependency and it is only used in tests which are disabled by default in this recipe. References: https://github.com/pybind/pybind11/blob/master/tests/CMakeLists.txt#L325 Moreover, the Boost is an enormously large and complex suite of utility libraries that cost the filesystem memory footprint of Embedded devices. Signed-off-by: Christian Ege <[email protected]> Signed-off-by: Pratik Manvar <[email protected]>
manvarpratik
force-pushed
the
kirkstone-remove-boost-dependency-for-python3-pybind11
branch
from
4176198
to
cc7550e
Compare
|
it should go to master branch first, I have cherry-picked to staging branch ( master-next ) into master since it is a simple cherry-pick, in future always check if the patch is needed on master branch first. |
Sure, I will keep this in mind. Thank you! |
|
applied to master with 086eeb4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boost is an optional dependency and it is only used in tests which are disabled by default in this recipe.
References:
https://github.com/pybind/pybind11/blob/master/tests/CMakeLists.txt#L325
Moreover, the Boost is an enormously large and complex suite of utility libraries that cost the filesystem memory footprint of Embedded devices.